Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for global init checker #21694

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

liufengyun
Copy link
Contributor

Add a test for global init checker

@olhotak
Copy link
Contributor

olhotak commented Oct 4, 2024

It would be good to add a comment about why this is an initialization error and/or how the enum is specified to be desugared. The desugaring rules are complicated, so a comment about how this particular case desugars would be helpful.

Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@olhotak olhotak merged commit f6c6ec6 into scala:main Oct 5, 2024
28 checks passed
@olhotak olhotak deleted the fliu/add-init-test branch October 5, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants