-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Performance improvement to global initialization checker #21514
Draft
liufengyun
wants to merge
27
commits into
scala:main
Choose a base branch
from
dotty-staging:liufengyun/improve-global-init
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP - Performance improvement to global initialization checker #21514
liufengyun
wants to merge
27
commits into
scala:main
from
dotty-staging:liufengyun/improve-global-init
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9460eb7 - Browse repository at this point
Copy the full SHA 9460eb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b95450 - Browse repository at this point
Copy the full SHA 6b95450View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cbc51b - Browse repository at this point
Copy the full SHA 5cbc51bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78c8c4a - Browse repository at this point
Copy the full SHA 78c8c4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b861a1 - Browse repository at this point
Copy the full SHA 7b861a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf1515f - Browse repository at this point
Copy the full SHA cf1515fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75c5ff0 - Browse repository at this point
Copy the full SHA 75c5ff0View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb485c0 - Browse repository at this point
Copy the full SHA cb485c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0af7e00 - Browse repository at this point
Copy the full SHA 0af7e00View commit details -
Fix crash due to out-of-band return values using return keyword
See test tests/init-global/warn/return2.scala
Configuration menu - View commit details
-
Copy full SHA for 9f61f34 - Browse repository at this point
Copy the full SHA 9f61f34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86e39de - Browse repository at this point
Copy the full SHA 86e39deView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8dbaeb - Browse repository at this point
Copy the full SHA a8dbaebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e69d03 - Browse repository at this point
Copy the full SHA 3e69d03View commit details -
Configuration menu - View commit details
-
Copy full SHA for a84a8d1 - Browse repository at this point
Copy the full SHA a84a8d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dd781c - Browse repository at this point
Copy the full SHA 4dd781cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77fc613 - Browse repository at this point
Copy the full SHA 77fc613View commit details -
Configuration menu - View commit details
-
Copy full SHA for c418982 - Browse repository at this point
Copy the full SHA c418982View commit details -
Don't apply memory optimization for constructor calls
Otherwise, the following program causes weird address not found error: import scala.collection.immutable.HashSet object A: val a = HashSet(1, 2, 3) The error looks like the following: -- Warning: out/bootstrap/scala2-library-bootstrapped/scala-3.6.0-RC1-bin-SNAPSHOT-nonbootstrapped/src_managed/main/scala-library-src/scala/collection/immutable/ChampCommon.scala:155:24 155 | currentStackLevel = currentStackLevel - 1 | ^^^^^^^^^^^^^^^^^ |[Internal error] Address not found FieldAddr(List(),val currentStackLevel,module class A$). Trace: |Calling trace: |├── object A: [ HashSet.scala:3 ] |│ ^ |├── val a = HashSet(1, 2, 3) [ HashSet.scala:4 ] |│ ^^^^^^^^^^^^^^^^ |├── def apply[A](elems: A*): CC[A] = from(elems) [ Factory.scala:103 ] |│ ^^^^^^^^^^^ |├── def from[A](source: collection.IterableOnce[A]): HashSet[A] = [ HashSet.scala:1939 ] |│ ^ |├── case _ => (newBuilder[A] ++= source).result() [ HashSet.scala:1943 ] |│ ^^^^^^^^^^^^^^^^^^^^^^^^ |├── @inline final def ++= (@deprecatedName("xs") elems: IterableOnce[A]): this.type = addAll(elems) [ Growable.scala:69 ] |│ ^^^^^^^^^^^^^ |├── override def addAll(xs: IterableOnce[A]) = { [ HashSet.scala:2079 ] |│ ^ |├── } [ HashSet.scala:2096 ] |│ ^ |├── new ChampBaseIterator[A, SetNode[A]](hm.rootNode) { [ HashSet.scala:2083 ] |│ ^ |├── while(hasNext) { [ HashSet.scala:2084 ] |│ ^^^^^^^ |├── final def hasNext = (currentValueCursor < currentValueLength) || searchNextValueNode() [ ChampCommon.scala:185 ] |│ ^^^^^^^^^^^^^^^^^^^^^ |├── private final def searchNextValueNode(): Boolean = { [ ChampCommon.scala:162 ] |│ ^ |├── popNode() [ ChampCommon.scala:178 ] |│ ^^^^^^^^^ |├── private final def popNode(): Unit = { [ ChampCommon.scala:154 ] |│ ^ |└── currentStackLevel = currentStackLevel - 1 [ ChampCommon.scala:155 ] | ^^^^^^^^^^^^^^^^^
Configuration menu - View commit details
-
Copy full SHA for 19d92aa - Browse repository at this point
Copy the full SHA 19d92aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 47f944d - Browse repository at this point
Copy the full SHA 47f944dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08b4e66 - Browse repository at this point
Copy the full SHA 08b4e66View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 59e5412 - Browse repository at this point
Copy the full SHA 59e5412View commit details
Commits on Sep 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6de4e60 - Browse repository at this point
Copy the full SHA 6de4e60View commit details
Commits on Sep 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7c909f4 - Browse repository at this point
Copy the full SHA 7c909f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdc2a66 - Browse repository at this point
Copy the full SHA fdc2a66View commit details -
Configuration menu - View commit details
-
Copy full SHA for f15ec64 - Browse repository at this point
Copy the full SHA f15ec64View commit details -
Fix cache for function and lazy vals
Otherwise, the test tests/init-global/pos/lazy-local-val2.scala would stackoverflow
Configuration menu - View commit details
-
Copy full SHA for aa27034 - Browse repository at this point
Copy the full SHA aa27034View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce87173 - Browse repository at this point
Copy the full SHA ce87173View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.