Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "bugfix: Exclude newer LSP4j, which is built on JDK 11" to LTS #21145

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Backport "bugfix: Exclude newer LSP4j, which is built on JDK 11" to LTS #21145

merged 1 commit into from
Jul 10, 2024

Commits on Jul 10, 2024

  1. bugfix: Exclude newer LSP4j, which is built on JDK 11 

    It seems the CI started failing because of out bump, but that was not picked up aside from windows tests weirdly.

Metals recently updated to newest LSP4j, though I think nothing new was added and no changes were done to the presentation compiler so we should be ok to downgrade locally: https://github.com/scalameta/metals/pull/6126/files

The update was mostly done so that we done fall behind in the LSP standard, but this might become a problem in the future here. Do we ever plan do drop supporting JDK 8?

[Cherry-picked 790bee9]
    @tgodzik @WojciechMazur
    tgodzik authored and WojciechMazur committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4296d2d View commit details
    Browse the repository at this point in the history