Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "fix(#19377): show inherited abstract members in dedicated section" to LTS #20881

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #19552 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

Before this commit, inherited abstract members are displayed in
"Inherited members" section, which made it a bit difficult for
developers to figure out which method to be implemented.

I think there are two solution for the issue.

1. display `abstract` modifier for methods in inherited section
2. add a new dedicated section for inherited abstract members

I choose the 2nd solution because

- it is easier for developers to find methods to be implemented in a dedicated section rather than to look
  up abstract ones from all the inherited members
- it requires smaller modification to scaladoc codebase

[Cherry-picked c823781]
Base automatically changed from lts-19592 to lts-3.3 July 1, 2024 08:41
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-19605.

Reference

@WojciechMazur WojciechMazur merged commit e12999e into lts-3.3 Jul 1, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the lts-19552 branch July 1, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants