Use sbt-native-packager instead of sbt-pack #20547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
force-pushed
the
msi-installer
branch
8 times, most recently
from
88a77b7
to
59daf47
Compare
hamzaremmal
force-pushed
the
msi-installer
branch
10 times, most recently
from
3096410
to
073ef51
Compare
hamzaremmal
force-pushed
the
msi-installer
branch
3 times, most recently
from
6eeb38f
to
7d59d4f
Compare
bishabosha
reviewed
Jul 2, 2024
hamzaremmal
force-pushed
the
msi-installer
branch
from
7d59d4f
to
70fc581
Compare
hamzaremmal
added a commit
that referenced
this pull request
Jul 11, 2024
In #20547, to be able to build an msi installer, the version needs to have the following pattern `A.B.C.D`. This change should be fine but the release procedure of RC1 will have to take it into account.
hamzaremmal
force-pushed
the
msi-installer
branch
6 times, most recently
from
61b0d9f
to
880d773
Compare
hamzaremmal
force-pushed
the
msi-installer
branch
from
880d773
to
7c996e5
Compare
|
Some changes are required in We will also be signing the released msi but we don't have yet a code signing certificate so the necessary changes will also follow in another PR |
bishabosha
reviewed
Jul 15, 2024
bishabosha
reviewed
Jul 15, 2024
project/Build.scala
Outdated
| maintainer := "The Scala Programming Language", | ||
| packageSummary := s"Scala $dottyVersion", | ||
| packageDescription := """Installer for the Scala Programming Language""", | ||
| wixProductId := "74ED19C3-74FE-4ABA-AF30-55A06B6322A9", |
There was a problem hiding this comment.
these GUIDs seem a bit underdocumented - where do they come from?
There was a problem hiding this comment.
I can add some documentation here
hamzaremmal
commented
Jul 15, 2024
bishabosha
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #20351.
The idea is to use
sbt-native-packagerinstead ofsbt-packsince it has the ability to generate.msifiles.[test_msi]