Refine overloading and implicit disambiguation #20084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We sometimes have two alternatives a.m and b.m with the same symbol but different prefixes. Previously these would always be ambiguous. We now try to disambiguate this so that the alternative with the more specific prefix wins. To determine this, we widen prefixes also going from module classes to their parents and then compare the resulting types. This might fix a problem in ScalaTest that popped up after scala#20054.
compareOwner did certain tests for one side but not for the other, which made its outcome dependent on the order in which alternatives were presented.
The alternatives with the same symbol could have nevertheless different types. We first want to disambiguate based on these types before we turn to prefixes as a final tie breaker.
odersky
force-pushed
the
change-implicit-disambiguation
branch
2 times, most recently
from
714c774
to
8eeee0b
Compare
|
It did not fix the ScalaTest problem but it's an improvement anyway. |
There was a problem hiding this comment.
The following example using an implicit parameter does not work as before
class I[X]
class J[X]
trait A:
given I[B] = ???
given (using I[B]): J[B] = ???
object A extends A
trait B extends A
object B extends B
//import B.given, A.given
def Test =
summon[I[B]]
summon[J[B]] // ErrorI tried an alternative here using the prefix comparison in both cases.
EugeneFlesselle
approved these changes
Apr 8, 2024
odersky
added a commit
that referenced
this pull request
Oct 5, 2024
Fix #21669 This part of code is from #20084 We should check `parents` is non-empty before calling `reduceLeft`. I haven't been able to create a standalone test. To test locally: `i21669.scala` ```scala //> using dep "com.softwaremill.sttp.tapir::tapir-sttp-client:1.11.5" import sttp.tapir.* import sttp.tapir.client.sttp.SttpClientInterpreter @main def run = lazy val pingGET = endpoint.get .in("ping") .out(stringBody) SttpClientInterpreter() .toRequest(pingGET, Some(uri"http://localhost:8080")) ``` ``` > sbt publishLocal > scala compile --server=false -S 3.6.0-RC1-bin-SNAPSHOT i21669.scala -- [E008] Not Found Error: /dotty/i21669.scala:12:33 ------ 12 | .toRequest(pingGET, Some(uri"http://localhost:8080")) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ |value uri is not a member of StringContext, but could be made available as an extension method. | |One of the following imports might fix the problem: | | import sttp.client3.UriContext | import sttp.client3.quick.UriContext | import sttp.model.Uri.UriContext | 1 error found Compilation failed ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes have two alternatives a.m and b.m with the same symbol and type but different prefixes. Previously these would always be ambiguous. We now try to disambiguate this so that the alternative with the more specific prefix wins. To determine this, we widen prefixes also going from module classes to their parents and then compare the resulting types.
This might fix a problem in ScalaTest that popped up after #20054.