Bring back old completions as a deprecated method #20042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florian3k
approved these changes
Mar 28, 2024
| @@ -255,8 +255,22 @@ class ReplDriver(settings: Array[String], | |||
| else | |||
| label | |||
|
|
|||
| @deprecated("Use completionsWithSignatures instead", "3.4.2") | |||
| protected final def completions(cursor: Int, expr: String, state0: State): List[Candidate] = | |||
There was a problem hiding this comment.
Is it java.util.List or scala.List. These were previously passed directly to the jline methods expecting java.util.Collection[? <: org.jline.reader.Candidate]
I assume it's java.util.List, but just want to be sure
WojciechMazur
approved these changes
Mar 28, 2024
Kordyjan
force-pushed
the
bring-back-old-completions
branch
from
845ee0c
to
73bb4cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.