Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag class file collision as error #19332

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Flag class file collision as error #19332

merged 3 commits into from
Oct 10, 2024

Conversation

Friendseeker
Copy link
Contributor

Fixes #19248

nicolasstucki
nicolasstucki suggested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a test that reproduces this issue and checks that the error is emitted.

I assume that we can create the folder tests/neg/i19248 and add the files from the original example in it. With the // error tag on the line that will emit the error.

@nicolasstucki nicolasstucki self-assigned this Feb 1, 2024
@nicolasstucki nicolasstucki removed their assignment Apr 12, 2024
@Friendseeker Friendseeker force-pushed the flag-class-file-collision-error branch from deb9456 to ac05bd5 Compare October 9, 2024 20:43
@Friendseeker
Copy link
Contributor Author

Nicolas's Github status says On vacation...

@smarter Would you like to take a really quick look at this PR? This PR is small and should be light to review.

smarter
smarter approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I was hit by this just recently!

@smarter smarter merged commit a72b97a into scala:main Oct 10, 2024
28 checks passed
@Friendseeker Friendseeker deleted the flag-class-file-collision-error branch October 10, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

@nicolasstucki nicolasstucki Awaiting requested review from nicolasstucki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class file collision is flagged as warning instead of error
3 participants
@Friendseeker @smarter @nicolasstucki