Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly compilation tests for Scala 2 library TASTy #18892

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 10, 2023

This adds a new CI test for the Scala 2 library TASTy configuration. We enable all testCompilation tests except a few that are blacklisted and need to be fixed at some point. This test only triggers on nightly builds or with the [test_scala2_library_tasty] tag. We also keep the current set of tests on every PR.

[test_scala2_library_tasty]

@nicolasstucki nicolasstucki self-assigned this Nov 10, 2023
@nicolasstucki nicolasstucki force-pushed the add-nightly-compilation-tests-for-scala2-library-tasty branch 3 times, most recently from 9178eb1 to 8382d5b Compare November 13, 2023 09:20
@nicolasstucki nicolasstucki marked this pull request as ready for review November 13, 2023 11:59
@nicolasstucki nicolasstucki force-pushed the add-nightly-compilation-tests-for-scala2-library-tasty branch from 8382d5b to 2f8acb9 Compare November 13, 2023 12:10
Run all tests with Scala 2 library TASTy with some failing tests blacklisted.
@nicolasstucki nicolasstucki force-pushed the add-nightly-compilation-tests-for-scala2-library-tasty branch 2 times, most recently from f70c6a3 to 2f636da Compare November 20, 2023 07:55
@nicolasstucki nicolasstucki force-pushed the add-nightly-compilation-tests-for-scala2-library-tasty branch from 2f636da to 726da0c Compare November 20, 2023 09:32
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bishabosha bishabosha merged commit f831830 into scala:main Nov 22, 2023
19 checks passed
@bishabosha bishabosha deleted the add-nightly-compilation-tests-for-scala2-library-tasty branch November 22, 2023 09:29
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants