Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion assert diffs will now show completion source #18890

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

rochala
Copy link
Contributor

@rochala rochala commented Nov 9, 2023

Previously failed assertions showed a side by side diff of expected vs obtained completions:

Screenshot 2023-11-09 at 18 28 46

And now:
Screenshot 2023-11-09 at 18 29 31

This is extremely useful when debugging the completions, as we have multiple sources and finding what specific completion comes from is just a waste of time.

There is also a chance that we'd want to not include this info in data, but this is minimal trade-off for a significant boost when working on PC.

@rochala rochala requested a review from tgodzik November 9, 2023 17:31
@rochala rochala merged commit e196dec into scala:main Nov 10, 2023
18 checks passed
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@tgodzik tgodzik added the area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools label May 8, 2024
WojciechMazur pushed a commit that referenced this pull request Jun 25, 2024
Previously failed assertions showed a side by side diff of expected vs
obtained completions:

<img width="275" alt="Screenshot 2023-11-09 at 18 28 46"
src="https://github.com/lampepfl/dotty/assets/48657087/c80fbc71-7e58-4cba-b302-b4dfeff9bcec">

And now:
<img width="311" alt="Screenshot 2023-11-09 at 18 29 31"
src="https://github.com/lampepfl/dotty/assets/48657087/829933c7-31c6-4c26-a20c-4d426eb5c11b">

This is extremely useful when debugging the completions, as we have
multiple sources and finding what specific completion comes from is just
a waste of time.

There is also a chance that we'd want to not include this info in data,
but this is minimal trade-off for a significant boost when working on
PC.
[Cherry-picked e196dec]
WojciechMazur added a commit that referenced this pull request Jun 26, 2024
… LTS (#20792)

Backports #18890 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants