Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show deprecation warning for _ in type match case #18887

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

nicolasstucki
Copy link
Contributor

Fixes #18808

@nicolasstucki nicolasstucki marked this pull request as ready for review November 10, 2023 10:42
@dwijnand dwijnand changed the title Do not show deprecation waning for _ in type match case Do not show deprecation warning for _ in type match case Nov 10, 2023
@nicolasstucki nicolasstucki merged commit d539605 into scala:main Nov 10, 2023
18 checks passed
@nicolasstucki nicolasstucki deleted the fix-18808 branch November 10, 2023 15:04
nicolasstucki added a commit that referenced this pull request Nov 14, 2023
Based on #18887
First part of #18869

* In `3.4` we emit the deprecation warning and enable the patch with
`-rewrite`.
* In `future` we emit we make this syntax an error

```scala
//> using options -source future
def f: F[_] = ??? // error
```
```diff
//> using options -rewrite -source 3.4-migration
- def f: F[_] = ???
+ def f: F[?] = ???
```
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

? in match type cases
4 participants