Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: rename end marker #18838

Merged
merged 1 commit into from
Nov 6, 2023
Merged

bugfix: rename end marker #18838

merged 1 commit into from
Nov 6, 2023

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek commented Nov 3, 2023 •
edited
Loading

metals backport scalameta/metals#5803

CC: @tgodzik

@sjrd sjrd requested a review from rochala November 3, 2023 16:17
tgodzik
tgodzik approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit 82d22c6 into scala:main Nov 6, 2023
18 checks passed
@tgodzik tgodzik added backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools labels Nov 6, 2023
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 23, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 23, 2024
@WojciechMazur
Backport "bugfix: rename end marker" to LTS (#20757)
a63b3db 
Backports #18838 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@rochala rochala Awaiting requested review from rochala

Assignees

@rochala rochala

Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it.
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kasiaMarek @tgodzik @Kordyjan @rochala