Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type inference for functions like fold #18780

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Improve type inference for functions like fold #18780

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c556aa
Improve type inference for functions like fold
odersky Oct 28, 2023
21f542b
Address review comments
odersky Nov 9, 2023
18cf1b4
Put back test in instantiate
odersky Nov 13, 2023
6f1a09a
Update compiler/src/dotty/tools/dotc/core/Types.scala
odersky Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion compiler/src/dotty/tools/dotc/core/Types.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4919,7 +4919,12 @@ object Types {
* is also a singleton type.
*/
def instantiate(fromBelow: Boolean)(using Context): Type =
instantiateWith(typeToInstantiateWith(fromBelow))
val tp = typeToInstantiateWith(fromBelow)
if myInst.exists then // The line above might have triggered instantiation of the current type variable
Member
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray line?

odersky marked this conversation as resolved.
Show resolved Hide resolved
myInst
else
instantiateWith(tp)

/** Widen unions when instantiating this variable in the current context? */
def widenUnions(using Context): Boolean = !ctx.typerState.constraint.isHard(this)
Expand Down
Loading