Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop network tests in requests community-build #17199

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Apr 3, 2023

No description provided.

@bishabosha
Copy link
Member

bishabosha commented Apr 3, 2023

In my experience httpbin.org itself can often have incredibly long response times, up to 1 minute, on all endpoints, not just /delay - so I think probably best to just prevent these tests

@nicolasstucki nicolasstucki merged commit b1470fa into scala:main Apr 3, 2023
@dwijnand
Copy link
Member

@Kordyjan there's also #17128, but this one is newer.

@dwijnand dwijnand added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Apr 17, 2023
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Apr 27, 2023
@SethTisue
Copy link
Member

I've reported the problem upstream at com-lihaoyi/requests-scala#132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:done This PR was successfully backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants