Skip to content

Commit

Permalink
Respect [skip-ci] comments in launchers and spec tests (#21472)
Browse files Browse the repository at this point in the history
Currently, Specification and Launchers CI would execute even when the
`skip ci` tag message is part of the PR. The goal of this change is to
ignore these jobs when annotated.
The only remaining CI job running under skip ci is `Scala CLA check`
  • Loading branch information
hamzaremmal authored Aug 28, 2024
2 parents a37da19 + 3bd4a7a commit e9e046d
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1017,6 +1017,12 @@ jobs:

build-sdk-package:
uses: ./.github/workflows/build-sdk.yml
if:
(github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]')) ||
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3') ||
(github.event_name == 'schedule' && github.repository == 'scala/scala3') ||
github.event_name == 'push' ||
github.event_name == 'merge_group'
with:
java-version: 8

Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/launchers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ jobs:
linux-x86_64:
name: Deploy and Test on Linux x64 architecture
runs-on: ubuntu-latest
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]') ) ||
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3' )
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
Expand Down Expand Up @@ -46,6 +48,8 @@ jobs:
mac-x86_64:
name: Deploy and Test on Mac x64 architecture
runs-on: macos-13
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]') ) ||
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3' )
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
Expand All @@ -65,6 +69,8 @@ jobs:
mac-aarch64:
name: Deploy and Test on Mac ARM64 architecture
runs-on: macos-latest
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]') ) ||
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3' )
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
Expand All @@ -84,6 +90,8 @@ jobs:
win-x86_64:
name: Deploy and Test on Windows x64 architecture
runs-on: windows-latest
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]') ) ||
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3' )
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ env:
jobs:
specification:
runs-on: ubuntu-latest
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]')) ||
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3') ||
github.event_name == 'push' ||
github.event_name == 'merge_group'
defaults:
run:
working-directory: ./docs/_spec
Expand Down

0 comments on commit e9e046d

Please sign in to comment.