refactor semanticdb

scala · Oct 25, 2023 · b072662 · b072662
1 parent 550c316
commit b072662
Showing 1 changed file with 46 additions and 37 deletions.
diff --git a/compiler/src/dotty/tools/dotc/semanticdb/ExtractSemanticDB.scala b/compiler/src/dotty/tools/dotc/semanticdb/ExtractSemanticDB.scala
@@ -25,6 +25,7 @@ import scala.jdk.CollectionConverters._
 import scala.PartialFunction.condOpt
 import typer.ImportInfo.withRootImports
 
+import dotty.tools.dotc.reporting.Diagnostic.Warning
 import dotty.tools.dotc.{semanticdb => s}
 import dotty.tools.io.{AbstractFile, JarArchive}
 import dotty.tools.dotc.semanticdb.DiagnosticOps.*
@@ -61,56 +62,64 @@ class ExtractSemanticDB private (phaseMode: ExtractSemanticDB.PhaseMode) extends
   // Check not needed since it does not transform trees
   override def isCheckable: Boolean = false
 
+  private def computeDiagnostics(
+      sourceRoot: String,
+      warnings: Map[SourceFile, List[Warning]],
+      append: ((Path, List[Diagnostic])) => Unit)(using Context): Boolean = monitor(phaseName) {
+    val unit = ctx.compilationUnit
+    warnings.get(unit.source).foreach { ws =>
+      val outputDir =
+        ExtractSemanticDB.semanticdbPath(
+          unit.source,
+          ExtractSemanticDB.semanticdbOutDir,
+          sourceRoot
+        )
+      append((outputDir, ws.map(_.toSemanticDiagnostic)))
+    }
+  }
+
+  private def extractSemanticDB(sourceRoot: String, writeSemanticdbText: Boolean)(using Context): Boolean =
+    monitor(phaseName) {
+      val unit = ctx.compilationUnit
+      val outputDir =
+        ExtractSemanticDB.semanticdbPath(
+          unit.source,
+          ExtractSemanticDB.semanticdbOutDir,
+          sourceRoot
+        )
+      val extractor = ExtractSemanticDB.Extractor()
+      extractor.extract(unit.tpdTree)
+      ExtractSemanticDB.write(
+        unit.source,
+        extractor.occurrences.toList,
+        extractor.symbolInfos.toList,
+        extractor.synthetics.toList,
+        outputDir,
+        sourceRoot,
+        writeSemanticdbText
+      )
+    }
+
   override def runOn(units: List[CompilationUnit])(using ctx: Context): List[CompilationUnit] = {
     val sourceRoot = ctx.settings.sourceroot.value
     val appendDiagnostics = phaseMode == ExtractSemanticDB.PhaseMode.AppendDiagnostics
+    val unitContexts = units.map(ctx.fresh.setCompilationUnit(_).withRootImports)
     if (appendDiagnostics)
       val warnings = ctx.reporter.allWarnings.groupBy(w => w.pos.source)
       val buf = mutable.ListBuffer.empty[(Path, Seq[Diagnostic])]
-      units.foreach { unit =>
-        val unitCtx = ctx.fresh.setCompilationUnit(unit).withRootImports
-        monitor(phaseName) {
-          warnings.get(unit.source).foreach { ws =>
-            val outputDir =
-              ExtractSemanticDB.semanticdbPath(
-                unit.source,
-                ExtractSemanticDB.semanticdbOutDir(using unitCtx),
-                sourceRoot
-              )
-            buf += ((outputDir, ws.map(_.toSemanticDiagnostic)))
-          }
-        }(using unitCtx)
-      }
+      val units0 =
+        for unitCtx <- unitContexts if computeDiagnostics(sourceRoot, warnings, buf += _)(using unitCtx)
+        yield unitCtx.compilationUnit
       cancellable {
         buf.toList.asJava.parallelStream().forEach { case (out, warnings) =>
           ExtractSemanticDB.appendDiagnostics(warnings, out)
         }
       }
+      units0
     else
       val writeSemanticdbText = ctx.settings.semanticdbText.value
-      units.foreach { unit =>
-        val unitCtx = ctx.fresh.setCompilationUnit(unit).withRootImports
-        monitor(phaseName) {
-          val outputDir =
-            ExtractSemanticDB.semanticdbPath(
-              unit.source,
-              ExtractSemanticDB.semanticdbOutDir(using unitCtx),
-              sourceRoot
-            )
-          val extractor = ExtractSemanticDB.Extractor()
-          extractor.extract(unit.tpdTree)(using unitCtx)
-          ExtractSemanticDB.write(
-            unit.source,
-            extractor.occurrences.toList,
-            extractor.symbolInfos.toList,
-            extractor.synthetics.toList,
-            outputDir,
-            sourceRoot,
-            writeSemanticdbText
-          )
-        }(using unitCtx)
-      }
-    units
+      for unitCtx <- unitContexts if extractSemanticDB(sourceRoot, writeSemanticdbText)(using unitCtx)
+      yield unitCtx.compilationUnit
   }
 
   def run(using Context): Unit = unsupported("run")