Reclassify test and improve error message

scala · Jun 26, 2023 · 1faade5 · 1faade5
1 parent bf6974e
commit 1faade5
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 9 deletions.
diff --git a/compiler/src/dotty/tools/dotc/parsing/Parsers.scala b/compiler/src/dotty/tools/dotc/parsing/Parsers.scala
@@ -2908,14 +2908,18 @@ object Parsers {
      */
     def pattern3(location: Location): Tree =
       val p = infixPattern()
-      if location.inArgs && followingIsVararg() then
+      if followingIsVararg() then
         val start = in.skipToken()
-        p match
-          case p @ Ident(name) if name.isVarPattern =>
-            Typed(p, atSpan(start) { Ident(tpnme.WILDCARD_STAR) })
-          case _ =>
-            syntaxError(em"`*` must follow pattern variable", start)
-            p
+        if location.inArgs then
+          p match
+            case p @ Ident(name) if name.isVarPattern =>
+              Typed(p, atSpan(start) { Ident(tpnme.WILDCARD_STAR) })
+            case _ =>
+              syntaxError(em"`*` must follow pattern variable", start)
+              p
+        else
+          syntaxError(em"bad use of `*` - sequence pattern not allowed here", start)
+          p
       else p
 
     /**  Pattern2    ::=  [id `@'] Pattern3

diff --git a/tests/neg/i8715.check b/tests/neg/i8715.check
@@ -0,0 +1,4 @@
+-- Error: tests/neg/i8715.scala:2:46 -----------------------------------------------------------------------------------
+2 |def Test = List(42) match { case List(xs @ (ys*)) => xs } // error
+  |                                              ^
+  |                                              bad use of `*` - sequence pattern not allowed here
diff --git a/tests/neg/i8715.scala b/tests/neg/i8715.scala
@@ -0,0 +1,2 @@
+@main
+def Test = List(42) match { case List(xs @ (ys*)) => xs } // error
diff --git a/tests/pos/i8715.scala b/tests/pos/i8715.scala