Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap SE-2 w/ hardhat for SE-2 w/ foundry #22

Merged
merged 1 commit into from
Dec 4, 2023
Merged

swap SE-2 w/ hardhat for SE-2 w/ foundry #22

merged 1 commit into from
Dec 4, 2023

Conversation

MattPereira
Copy link
Collaborator

@MattPereira MattPereira commented Dec 3, 2023

Summary

  • deleted everything on main branch except the README that is specific to defi challenges repo
  • used npx create-eth@latest command and selected foundry option

Local Testing

  1. run yarn to install dependencies
  2. run yarn chain to spin up local network
  3. run yarn start to see frontend at localhost:3000
  4. run yarn deploy to deploy contracts on local foundry network

TODO

@steve0xp
Copy link
Collaborator

steve0xp commented Dec 3, 2023

Looks good to me, except we need to resolve the failing checks.

@steve0xp steve0xp self-requested a review December 3, 2023 21:51
Copy link
Collaborator

@steve0xp steve0xp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on our call, this looks good. We are troubleshooting why the linter is failing but that might be more of a Scaffold-ETH problem with their workflow file.

@steve0xp
Copy link
Collaborator

steve0xp commented Dec 4, 2023

The failing CI is something that Shiv Bhonde has brought up to us. It is being discussed in this issue I believe. So we can move ahead and have this merged to main and git pull SE-2 into the other challenge branches, and future branches onward!

Great job again :)

@MattPereira MattPereira merged commit bb85efd into scaffold-eth:main Dec 4, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants