Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle javac warning messages #1228

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

Arthurm1
Copy link
Contributor

Javac warnings on bad options are currently not handled so subsequent errors/warnings in code are ignored.

Fixes #1188

@Arthurm1
Copy link
Contributor Author

I've now signed the CLA

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arthurm1 Thanks for the contribution!

@eed3si9n
Copy link
Member

eed3si9n commented Jul 27, 2023

CONTRIBUTING I think is out of date. CLA that's required is Scala CLA https://www.lightbend.com/contribute/cla/scala

@Arthurm1
Copy link
Contributor Author

@eed3si9n I think I've signed the right one now. https://www.lightbend.com/contribute/cla/scala/check/Arthurm1 comes back with true

@eed3si9n eed3si9n merged commit b7e4d7d into sbt:develop Jul 28, 2023
6 of 7 checks passed
@Arthurm1 Arthurm1 deleted the javac_warnings branch July 29, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java options warning not handled
2 participants