Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#350: Add Nox and basic pyproject.toml created by Poetry #353

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

nifadyev
Copy link
Contributor

Resolves #350

CC @satwikkansal

- Use new structure for code blocks in README
@nifadyev nifadyev force-pushed the #350/add-nox-support branch from 57c94dc to f251561 Compare October 24, 2024 04:53
@satwikkansal
Copy link
Owner

@nifadyev looks good, thanks, instead of merging into master, could you raise a PR against the dev branch please. We can merge in master when we've translated all the snippets to the new layout.

@nifadyev
Copy link
Contributor Author

No problem, @satwikkansal. But in my opinion, it is more difficult to check and release huge PR than lots of small changes (so-called Trunk based development). I remember how I made a translation, and it was a pain to check it before merging.

@satwikkansal
Copy link
Owner

But in my opinion, it is more difficult to check and release huge PR than lots of small changes (so-called Trunk based development). I remember how I made a translation, and it was a pain to check it before merging.

I agree, think of master branch as production code. And dev branch for staging code. That doesn't mean we have to merge long PRs into the dev branch, we can still merge code incrementally in dev branch. And when we've tested the dev branch for consistency, then we can merge dev into master, that one will be a big PR, yes, but there won't be anything as such that hasn't been reviewed already carefully, so we should be good. Let me know your thoughts.

@nifadyev
Copy link
Contributor Author

Agreed, I will start making small PRs into dev branch. It would be awesome to create “parent” issue with good first issue label and track the progress there. I hope the label will attract some contributors.

@satwikkansal
Copy link
Owner

Great, feel free to create the issue, I'll put the label 👍

@nifadyev
Copy link
Contributor Author

Hey @satwikkansal , I don't have privileges to create new branches. Could you please create dev and delete irrelevant development and 3.0?

@satwikkansal
Copy link
Owner

@nifadyev Done!

@nifadyev nifadyev changed the base branch from master to dev November 2, 2024 04:27
@nifadyev
Copy link
Contributor Author

nifadyev commented Nov 5, 2024

@satwikkansal , base branch has been changed to dev

@satwikkansal
Copy link
Owner

@nifadyev there's one merge conflict, could you resolve it please, I'll merge post that!

@nifadyev
Copy link
Contributor Author

nifadyev commented Nov 5, 2024

@satwikkansal , thanks for noticing, the merge conflict has been resolved
Probably, markdownlint CI check should be optional for now since markdown files are not fully fixed yet

@satwikkansal
Copy link
Owner

Yes, that's okay, I was wondering maybe we should increase the line length to 180, we can have separate linter for Python code and have line length set to a lower value there.

@satwikkansal satwikkansal merged commit af07227 into satwikkansal:dev Nov 5, 2024
1 check failed
@nifadyev
Copy link
Contributor Author

nifadyev commented Nov 5, 2024

we should increase the line length to 180, we can have separate linter for Python code

Sure, will be changed in next PRs

@nifadyev nifadyev deleted the #350/add-nox-support branch November 5, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nox with supported Python versions to test snippets
2 participants