Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support Ruby 3.3 and Rails 7.2 #6913

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Conversation

randalldfloyd
Copy link
Contributor

First try at building/testing Ruby 3.3 and Rails 7.2

Copy link

github-actions bot commented Oct 2, 2024

Test Results

    17 files  ± 0      17 suites  ±0   8h 36m 15s ⏱️ + 6h 19m 14s
 6 731 tests +17   6 302 ✅  - 114  297 💤 ±0  132 ❌ +131 
13 236 runs  +38  12 623 ✅  - 178  400 💤 +4  213 ❌ +212 

For more details on these failures, see this check.

Results for commit abc450c. ± Comparison against base commit ce352d3.

This pull request removes 287 and adds 304 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f4c91329b20>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f5a5d316190>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f4c913234a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f5a5ccbe108>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 5faf76b0-f1c3-463c-a810-c949ff82ca10
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 0616b72f-4864-4106-917c-14814c2063ae
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 77cc5cf9-070d-4e00-826a-6ff3118aaf79
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: ae5e62bb-04a5-4e2e-be24-aaee463c59a8
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: e189b8bb-7af6-442a-ad06-5c29a205ad2a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 5926475f-4e52-4dfe-b636-b80a92c3ba3d
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc9a5b7fdd8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fcefadb9608>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc9a5d4dc00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fceffc4bcd0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 610782aa-f511-4219-a1e8-78f9c4b260fc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: de136e45-fc17-4416-b460-c1e8d74ff573
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 37878bb8-0807-4f64-9d79-38cf9cb3ce17
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: b4c6ab88-99f4-449c-bc06-41cafa5a6ecf
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 85578c93-5196-4275-965a-d8720da81309
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: fe425e43-042c-476c-b0fe-25698b9220f1
…

♻️ This comment has been updated with latest results.

@cjcolvar cjcolvar force-pushed the ruby-3.3_rails-7.2 branch 2 times, most recently from d2d1d8e to c54a552 Compare October 2, 2024 22:27
@randalldfloyd randalldfloyd force-pushed the ruby-3.3_rails-7.2 branch 10 times, most recently from fcb8a71 to 66bdb99 Compare October 10, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants