-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switches Depositor values from Creator to Depositor. #6780
Open
bwatson78
wants to merge
1
commit into
main
Choose a base branch
from
corrects_workflow_depositor_values
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwatson78
added
bug
notes-minor
Release Notes: Non-breaking features
notes-bugfix
Release Notes: Fixed a bug
labels
Apr 22, 2024
Test Results 17 files ±0 17 suites ±0 2h 19m 11s ⏱️ - 2m 15s Results for commit dc70330. ± Comparison against base commit 59a42ad. This pull request removes 273 and adds 273 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
bwatson78
force-pushed
the
corrects_workflow_depositor_values
branch
from
July 24, 2024 16:16
77f678a
to
dc70330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switches Depositor values from Creator to Depositor.
Type of change (for release notes)
Add an appropriate
notes-*
label to the PR (or indicate here) that classifies this change.Choose from:
notes-minor
New Features that are backward compatiblenotes-bugfix
Bug FixesDetailed Description
Pulls the actual depositor of the Work object instead of the Creator. Creator would be an acceptable value in applications that would always consider the Creator of the Work to be the Depositor, but in archive applications using Hyrax, that's not the case.
@samvera/hyrax-code-reviewers