Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches Depositor values from Creator to Depositor. #6780

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bwatson78
Copy link
Contributor

Summary

Switches Depositor values from Creator to Depositor.

Type of change (for release notes)

Add an appropriate notes-* label to the PR (or indicate here) that classifies this change.

Choose from:

  • notes-minor New Features that are backward compatible
  • notes-bugfix Bug Fixes

Detailed Description

Pulls the actual depositor of the Work object instead of the Creator. Creator would be an acceptable value in applications that would always consider the Creator of the Work to be the Depositor, but in archive applications using Hyrax, that's not the case.

@samvera/hyrax-code-reviewers

@bwatson78 bwatson78 added bug notes-minor Release Notes: Non-breaking features notes-bugfix Release Notes: Fixed a bug labels Apr 22, 2024
@bwatson78 bwatson78 self-assigned this Apr 22, 2024
Copy link

github-actions bot commented Apr 22, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 19m 11s ⏱️ - 2m 15s
 6 705 tests ±0   6 408 ✅ +1  297 💤 ±0  0 ❌  - 1 
13 178 runs  ±0  12 783 ✅ +1  395 💤 ±0  0 ❌  - 1 

Results for commit dc70330. ± Comparison against base commit 59a42ad.

This pull request removes 273 and adds 273 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f14897bd708>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fba83ec5c80>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f148a194600>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fba83ffc450>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 133a9822-768b-48ad-a346-396b70d63b8b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: d2a1f5ab-99e3-4f8a-af33-0f3fdb07e5a2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: c5cdc4e2-8185-4228-a98c-b012fbea7e7f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 67871b8d-cc2d-4fee-8a21-c9ae70f921ec
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 84ed5efd-d6ce-4bf0-9187-6e1f28380843
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 7f6fdad7-4891-48e5-b492-1da2b3ab04db
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f2b70d8eee0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc86034c6c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f2b707d9888>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc8605b4750>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 1488293a-88c0-48e8-a850-853aab6dd9b8
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: a8e91945-00e0-46cd-8b79-0122dc4542d3
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: b84e05ee-da0c-48ec-ba90-f7bce4c7a268
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 6e5da2fa-d16f-4e29-bd14-1ea823659a47
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: dde28b68-753a-43d2-bfcf-71494f4b36b6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: fe845e3b-be20-4a8f-88fc-9c6b117b4186
…

♻️ This comment has been updated with latest results.

@bwatson78 bwatson78 force-pushed the corrects_workflow_depositor_values branch from 77f678a to dc70330 Compare July 24, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug notes-bugfix Release Notes: Fixed a bug notes-minor Release Notes: Non-breaking features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant