Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a LICENSE.md file for the various test files. #768

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add a LICENSE.md file for the various test files. #768

wants to merge 4 commits into from

Conversation

jkbonfield
Copy link
Contributor

These are my own work on behalf of GRL. SAM / VCF may take more digging to correctly attribute ownership in order to categorically obtain a license statement, so they have been omitted in this commit.

WIP: will consider SAM next, but likely its own commit.

@jkbonfield jkbonfield mentioned this pull request Apr 22, 2024
Open
@jkbonfield jkbonfield force-pushed the test_license branch 2 times, most recently from f62cfb5 to 2ec76c2 Compare April 26, 2024 08:50
@jkbonfield
Copy link
Contributor Author

Added SAM, SAMtags, BAM and VCF LICENSE.md files too.

@d-cameron could you please tell me what copyright you want to list for your VCF files and confirm you're happy to just use the same Apache-2.0 licensing as everything else? See https://github.com/jkbonfield/hts-specs/blob/test_license/test/vcf/LICENSE.md

@jkbonfield jkbonfield changed the title Add a LICENSE.md file for the various CRAM test files. Add a LICENSE.md file for the various test files. May 7, 2024
@jkbonfield jkbonfield marked this pull request as ready for review July 16, 2024 13:32
@jmarshall
Copy link
Member

First trivial comment is that, in this repo, I'd rather see these as plain text in files named LICENSE.

@jkbonfield
Copy link
Contributor Author

I'm curious why. We already have README.md and MAINTAINERS.md. Markdown is, by definition, both plain text to people doing a git clone and viewing with e.g. less, as well as a bit better formatted for web browsing.

I could switch to just plain text, but I'd like to know the logic behind it first.

@jkbonfield
Add a LICENSE.md file for the various CRAM test files.
65b199b 
These are my own work on behalf of GRL.  SAM / VCF may take more
digging to correctly attribute ownership in order to categorically
obtain a license statement, so they have been omitted in this commit.
@jkbonfield
Add SAM, SAMtags and BAM test file LICENSE.md.
5877aab 
These are almost entirely added by GRL (Sanger) with the exception of
one added by John Marshall (Uni of Glasgow).
@jkbonfield
Add copyright / licensing statement for VCF test data.
e947d73 
The bulk of the data comes from EBI's vcf-validator at
https://github.com/EBIvariation/vcf-validator

A few new ones have appeared since, and some appear to be of 1000
genomes origin.
@jkbonfield
Renamed LICENSE.md to LICENSE following review
7f01aac 
Also some minor tweakage of text.  In particular
examples/vcf/simple.vcf is from VCFv3.1.tex and / or VCFtools, but
there is no evidence which came first and they both have differing
copyright statements.  (All we can do is state what is known and
unknown.)
@jkbonfield
Copy link
Contributor Author

Updated a few small things.

  • renamed to LICENSE

  • Expanded on examples/vcf/simple.vcf. I still don't know the origin. It's in VCF early specs as an example, but it's also in VCFtools in various forms (by different authors as it progresses through the spec versions). No idea if VCF example in the spec is copied from VCFtools or vice versa, but they have differing licenses (including LGPL) to make matters more confusing.

@d-cameron
Copy link
Contributor

Happy with the same license as everything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jmarshall jmarshall

@d-cameron d-cameron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkbonfield @jmarshall @d-cameron