Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Alleles (PR #434) applied to VCFv4.4 #745

Closed
wants to merge 6 commits into from

Conversation

jmarshall
Copy link
Member

This draft PR applies #434's Local Allele changes to the VCFv4.4 document on top of current master. It is not intended to split the conversation from the existing PR, but to provide a preview PDF and demonstration of how this applies to current v4.4.

If the PR author and VCF maintainers agree, and wish to apply the local alleles additions to v4.4 instead of v4.3 (or perhaps to both), then we can force push #434's branch to this commit, close this PR, and continue the conversation on the original PR.

@jmarshall jmarshall added the vcf label Nov 13, 2023
Copy link

Changed PDFs as of 4e4bae4: VCFv4.4 (diff).

@jmarshall
Copy link
Member Author

Incidentally, diff PDF previews include all pages rather than only the changed pages due to a ghostscript bug that was fixed two months ago but has not yet appeared in a release. So that's fun…

@jmarshall
Copy link
Member Author

@d-cameron: Please comment (or just do it!) on whether you wish to convert PR #434 to apply to the VCFv4.4 document by force-pushing this PR's HEAD to Yossi's PR's branch.

@jmarshall
Copy link
Member Author

PR #434 now contains this update.

@jmarshall jmarshall closed this Jan 2, 2024
@jmarshall jmarshall deleted the vcf44_local_alleles branch January 2, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

1 participant