Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): move to controls sub-directory #136

Merged
merged 2 commits into from
Aug 18, 2019
Merged

fix(tests): move to controls sub-directory #136

merged 2 commits into from
Aug 18, 2019

Conversation

myii
Copy link
Member

@myii myii commented Aug 18, 2019

  • Semi-automated using ssf-formula (v0.7.0)

Came across this while working with ssf-formula, planning the matrix upgrade to replace the EOL pre-salted images. Noticed that none of the InSpec tests were running. Also found that Fedora can now be re-enabled, after the issues encountered during #129 and #132.

@myii myii merged commit c00b054 into saltstack-formulas:master Aug 18, 2019
@myii
Copy link
Member Author

myii commented Aug 18, 2019

Self-merging due to the importance of having the tests running (and the formula itself not being affected).

CC: @daks.

@myii myii deleted the bug/fix-tests-not-running branch August 18, 2019 23:00
@saltstack-formulas-travis

🎉 This PR is included in version 0.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@daks
Copy link
Member

daks commented Aug 19, 2019

Do you mean that the tests (introduced by my code) were never run?! Wooh, nice catch then!

@myii
Copy link
Member Author

myii commented Aug 19, 2019

@daks No, it's not that bad! The tests were running but the introduction of test/integration/default/inspec.yml in #133 meant that it was now looking for the controls sub-directory, as outlined under the Profile Structure section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants