-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature | Show request endpoint in MockClient exception message #269
Conversation
PR Summary 😊
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @Joel-Jensen. Would you mind checking over PHP-Stan as well as update any tests to include this? Thank you!
@Joel-Jensen The only thing you should need to do is rebase from latest v3, where Sam recently downgraded the PHP constraint (8.2 -> 8.1) in composer.json. I can't see anything that PHPStan should complain about in your actual code changes. 👍 |
Seems like that branch isn't that stable right now, should I just merge this to v2? |
@Joel-Jensen I can get the tests passing for v3 - I'll sort this a little bit later. Happy to leave PHPStan for now as v3 isn't ready yet |
If you catch up with master now, it should pass 👍 |
Thanks @Joel-Jensen ! |
PR for my feature request in #219 (comment)
Displays the missing endpoint in the exception for easier debugging tests.
How Laravel,
Http::preventStrayRequest()
does it:This PR:
Before this PR: