Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JavaScrip files to make select folder work in User Preferences RE: 277 #282

Open
wants to merge 2 commits into
base: hotfix
Choose a base branch
from

Conversation

pstevens71
Copy link

Description

There were a few problems with these two files. groupFolders weren't being added to the array properly and once added the --None-- value had to be dealt with in the groupFolders array. Also, the click/select function wasn't working properly.

Motivation and Context

How To Test This

once all changes are applied in #277 and a user is added to a security group along with the inbound email account, it will show up properly for the user to select and view in the emails module.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • [x ] My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • [ x] I have read the How to Contribute guidelines.

Folders weren't being selected properly and the folders were refreshing with every click.  Group folders are already in the array, this caused duplicates.
Changes required to properly display the groupFolders array in the select, to remove the --None--- at the top of the groupFolders array and process the userFolders array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant