Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added two missing difference sets, updated URLs #38755

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Added two missing difference sets, updated URLs #38755

wants to merge 6 commits into from
+58 −15

Conversation

dmgordo
Copy link

@dmgordo dmgordo commented Oct 2, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited
Loading

Documentation preview for this PR (built with commit f711216; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

dimpase
dimpase approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Can you perhaps add the info on the groups in the non-cyclic examples?

@dmgordo
Copy link
Author

dmgordo commented Oct 4, 2024

Nice. Can you perhaps add the info on the groups in the non-cyclic examples?

I added some information. Let me know if that's what you had in mind.

@dimpase
Copy link
Member

dimpase commented Oct 4, 2024

looks good, let's wait for CI to finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

Assignees
No one assigned
Labels
c: combinatorial designs c: combinatorics s: positive review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmgordo @dimpase @kwankyu