Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of Chow ring ideal and Chow ring classes #38281

Draft
wants to merge 113 commits into
base: develop
Choose a base branch
from
Draft

Addition of Chow ring ideal and Chow ring classes #38281

wants to merge 113 commits into from

Conversation

25shriya
Copy link
Contributor

@25shriya 25shriya commented Jun 26, 2024 •
edited
Loading

This PR is focused on addition of classes for Chow ring ideal and Chow ring of matroids.
Check relevant issue.
The ideals classes consist of the Chow ring ideal and Augmented Chow ring ideal, with Gröbner basis for each of them.

The Chow ring class is an initial version.
@tscrim

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 980c63f; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tscrim tscrim self-requested a review June 27, 2024 16:43
25shriya and others added 30 commits September 24, 2024 09:53
@25shriya
Fixed typos in groebner_basis() method
f01279a
@25shriya
Added LaTeX method for the ideals
d0fb2ba
@25shriya
Edited definintions for augmented Chow ring ideal
3ed13fa
@25shriya
Fixed definitions of augmented Chow ring ideals
db165d7
@25shriya
Edited groebner_basis() method for all 3 ideals
88b20fb
@25shriya
Edited chow_ring() function examples
4669fd6
@25shriya
Edited Doctests
a84a41d
@25shriya
Edited doctests for ideals
e45f4b9
@25shriya
Edited basis() method for all 3 cases
ffd3fef
@25shriya
Added hyperlinks to ideals definitions in chow_ring.py
e2faf65
@25shriya
Changed ChowRingIdeal_nonaug._gens_constructor()
8505fa7
@25shriya
Changed definition of the non aug ideal
9c928e2
@25shriya
Edited documentation of ideals file
03355c9
@25shriya
Merge branch 'sagemath:develop' into chow_ring
484013c
@25shriya
Formatted doctests in chow_ring.py
629baa2
@25shriya
Formatted doctests in the ideals file
cd3a3fc
@25shriya
Corrected doctest outputs
bdfded8
@25shriya
Corrected linting errors for ideals file
91bc8e0
@25shriya
Corrected linting errors in ideals file
b9556d8
@25shriya
Corrected doctest output
cfb1fbb
@25shriya
Corrected linting error
231cb1f
@25shriya
Resolved linting errors
7b60d51
@25shriya
Optimized basis() method for all 3 cases
12e8d93
@25shriya
Corrected doctests for Element() subclass
6a72bd3
@25shriya
Corrected linting errors in ideals file
31b7afb
@25shriya
Corrected linting errors in chow_ring.py
e36e4ea
@25shriya
Corrected linting errors in ideals file
9221947
@25shriya
Tested ideals file
4156022
@25shriya
Corrected basis() method
35fd32b
@25shriya
Fixed linting error in matroid.pyx
7710eb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
c: algebra c: combinatorics c: matroid theory gsoc: 2024 Tag for GSoC2024 issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@25shriya @tscrim