Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staging: add workspace-wide rustfmt lints #552

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

staging: add workspace-wide rustfmt lints #552

wants to merge 6 commits into from

Commits on Nov 24, 2023

  1. sound: upgrade to 2021 Rust edition 

    There's no reason to use 2018, 2021 is the default nowadays.

Switch the versions in the rustfmt files of sound and video while at it.

Signed-off-by: Manos Pitsidianakis <[email protected]>
    @epilys
    epilys committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    a11b4ce View commit details
    Browse the repository at this point in the history

  2. staging: move rustfmt.toml to workspace directory 

    Both staging crates had the same rustfmt.toml file, let's make it
workspace default.

Signed-off-by: Manos Pitsidianakis <[email protected]>
    @epilys
    epilys committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    e576905 View commit details
    Browse the repository at this point in the history

  3. .buildkite: add nightly rustfmt check in staging 

    Add a new test json file with a cargo-fmt check with the nightly
toolchain. This allows to use nightly rustfmt rules in rustfmt.toml.

Signed-off-by: Manos Pitsidianakis <[email protected]>
    @epilys
    epilys committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    261a881 View commit details
    Browse the repository at this point in the history

  4. staging/rustfmt.toml: update 

    Add doc comments for each rule and a bunch of new rules.

Signed-off-by: Manos Pitsidianakis <[email protected]>
    @epilys
    epilys committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    25ef9da View commit details
    Browse the repository at this point in the history

  5. staging: fix rustfmt lints from previous commit 

    Signed-off-by: Manos Pitsidianakis <[email protected]>
    @epilys
    epilys committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    61d211d View commit details
    Browse the repository at this point in the history

  6. Add .git-blame-ignore-revs file 

    Add previous formatting commit SHA to .git-blame-ignore-revs

The filename does not seem to be standardised, but must be configured
explicitly.

Note: to use this file always, you must set:

  git config --local blame.ignoreRevsFile .git-blame-ignore-revs

(or --global)

or use git blame with `--ignore-revs-file .git-blame-ignore-revs`

Signed-off-by: Manos Pitsidianakis <[email protected]>
    @epilys
    epilys committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    58ab804 View commit details
    Browse the repository at this point in the history