Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV 1.59: Remove libc requirement for x86_64-*-linux-none #461

Closed
wants to merge 3 commits into from

Conversation

briansmith
Copy link
Contributor

No description provided.

@briansmith briansmith changed the title Remove libc requirement for x86_64-*-linux-* and support x86_64-*-linux-none MSRV 1.59: Remove libc requirement for x86_64-*-linux-* and support x86_64-*-linux-none Jun 6, 2024
@briansmith briansmith force-pushed the b/syscall-x86_64 branch 5 times, most recently from 6533252 to c60c94e Compare June 6, 2024 20:24
Prepare for removing the libc dependency from it.
Make progress on reoving the libc dependency from util_unix, so we
can remove the libc dependency for x86_64-unknown-linux-none.
}
match Word::try_from(ret) {
Ok(written) => {
const _:() = assert!(core::mem::size_of::<Word>() <= core::mem::size_of::<usize>());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on whether/how #463 is resolved, we may need to unpoison(dest, written) here.

0,
)
};
const _:() = assert!(core::mem::size_of::<libc::c_long>() == core::mem::size_of::<isize>());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and here.

@briansmith briansmith marked this pull request as ready for review June 7, 2024 15:37
@briansmith
Copy link
Contributor Author

Since the current implementation already doesn't work in MSAN (on Linux), we don't have to block this on MSAN support.

@briansmith briansmith force-pushed the b/syscall-x86_64 branch 2 times, most recently from 3ad27bf to 37386af Compare June 7, 2024 16:24
//
// #[cfg(target_abi = "x832")]
// #[allow(non_upper_case_globals)]
// pub const SYS_getrandom: IWord = 318 | __X32_SYSCALL_BIT;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't clear to me that we actually need to use __X32_SYSCALL_BIT for x86_64-unknown-linux-gnux32 and other x32 targets. It seems like we could just use the 64-bit version of the syscall instead (i.e. same syscall number). But I am not so sure and it's hard for me to test x32.

…-none.

Remove the last libc dependency from `linux_android`, as a step
towards supporting x86_64-unknown-linux-none.

This requires bumping the MSRV to 1.59.
@briansmith briansmith changed the title MSRV 1.59: Remove libc requirement for x86_64-*-linux-* and support x86_64-*-linux-none MSRV 1.59: Remove libc requirement for x86_64-*-linux-none and support x86_64-*-linux-none Jun 7, 2024
@briansmith briansmith changed the title MSRV 1.59: Remove libc requirement for x86_64-*-linux-none and support x86_64-*-linux-none MSRV 1.59: Remove libc requirement for x86_64-*-linux-none Jun 7, 2024
@newpavlov
Copy link
Member

Closing in favor of #520

@newpavlov newpavlov closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants