Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat other items as functions for the purpose of type-based search #131806

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lolbinarycat
Copy link
Contributor

specifically, constants and statics are nullary functions, and struct fields are unary functions.

fixes #130204

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 16, 2024
@rust-log-analyzer

This comment has been minimized.

@notriddle
Copy link
Contributor

The test failure in the gui test doesn't seem like a bug. It really is finding an item that it didn't use to find. You can just bump the number.

@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2024

Some changes occurred in GUI tests.

cc @GuillaumeGomez

@rust-log-analyzer

This comment has been minimized.

@notriddle notriddle added T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 17, 2024
@notriddle
Copy link
Contributor

Looks nice

image

@rfcbot poll is this a good idea?

@rfcbot
Copy link

rfcbot commented Oct 17, 2024

Team member @notriddle has asked teams: T-rustdoc-frontend, for consensus on:

is this a good idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc search: find types containing some other type
5 participants