-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize unsigned and float variants of num_midpoint
feature
#131784
base: master
Are you sure you want to change the base?
Conversation
@rfcbot fcp merge |
Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
This absolutely is 👍 from me. (Thanks for the ping!) I'm a fan of it as described here where it's consistent with That said, I feel obliged to mention that in the tracking issue that some people want |
Actually, @Urgau , consider putting "and float" in the title & OP here. To me the "stabilize the unsigned variants" text wouldn't include floats, since they're obviously signed. |
num_midpoint
featurenum_midpoint
feature
num_midpoint
featurenum_midpoint
feature
Float |
This PR proposes that we stabilize the unsigned variants of the
num_midpoint
feature as well as the floats variants, since they are not subject to any unresolved questions, which is equivalent to doing(a + b) >> 1
or(a + b) / 2
in a sufficiently large number.The stabilized API surface would be:
The signed variants
u{8,16,32,64,128,size}
would remain gated, until a decision is made about the rounding mode, in other words that the unresolved questions are resolved.cc @rust-lang/libs-api
cc @scottmcm
r? libs-api