fix: Change rootfs compression to gzip #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pendo324
approved these changes
Aug 24, 2023
vsiravar
force-pushed
the
vsiravar/rootfs-gzip
branch
from
c4bc81a
to
d1d9e4f
Compare
pendo324
reviewed
Aug 25, 2023
vsiravar
force-pushed
the
vsiravar/rootfs-gzip
branch
3 times, most recently
from
023edd6
to
5ef47e9
Compare
pendo324
approved these changes
Aug 25, 2023
|
Do we need to update |
vsiravar
force-pushed
the
vsiravar/rootfs-gzip
branch
from
5ef47e9
to
3f13d61
Compare
Signed-off-by: Vishwas Siravara <[email protected]>
vsiravar
force-pushed
the
vsiravar/rootfs-gzip
branch
from
3f13d61
to
628aca0
Compare
This is a good point. However the Makefile is updated when https://github.com/runfinch/finch-core/blob/main/.github/workflows/update-dependencies.yaml#L32 action runs. For the next run we still need https://github.com/runfinch/finch-core/blob/main/bin/update-rootfs.sh#L5 as the Makefile has a zst compressed tar. Once the change is merged, I will update the |
austinvazquez
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Change compression of rootfs bundle to gzip since windows does not come with zstd installed.
Testing done:
Yes, locally.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.