Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use bash instead of sh #135

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

ginglis13
Copy link
Contributor

@ginglis13 ginglis13 commented Aug 4, 2023

Issue #, if available:

Description of changes:

The action "Sync Submodules and Dependencies" on finch failed with the message "set: Illegal option -o pipefail". Also, there was an error interpreting [[ in the update-deps.sh script as [[ is bash syntax, but the shebang is set as sh

https://github.com/runfinch/finch/actions/runs/5760444005/job/15616416221

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ginglis13 ginglis13 changed the title fix: remove set flags from update rootfs script fix: use bash instread of sh in update rootfs script Aug 4, 2023
The action "Sync Submodules and Dependencies" on finch failed with the
message "set: Illegal option -o pipefail". Also, there was an error
interpreting `[[` in the update-deps.sh script as `[[` is bash syntax,
but the shebang is set as sh

Use bash instead of sh

https://github.com/runfinch/finch/actions/runs/5760444005/job/15616416221

Signed-off-by: Gavin Inglis <[email protected]>
@ginglis13 ginglis13 changed the title fix: use bash instread of sh in update rootfs script ci: use bash instead of sh Aug 4, 2023
Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@ginglis13 ginglis13 merged commit a8288ed into runfinch:main Aug 4, 2023
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants