Skip to content

Commit

Permalink
fix: quote recursive calls to make (#133)
Browse files Browse the repository at this point in the history
Issue #, if available:

*Description of changes:*

$(MAKE) is used for calling `make` recursively. On a Windows machine,
`make` might be at some location containing a space or special
character, like /c/Program Files (x86)/GnuWin32/bin/make . Wrap in
quotes as "$(MAKE)" to prevent errors.



*Testing done:*

`make` on macOS and Windows.


- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Gavin Inglis <[email protected]>
  • Loading branch information
ginglis13 authored Aug 3, 2023
1 parent cc59ef9 commit 1b7aeb2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ lima-template: download
lima-socket-vmnet:
git submodule update --init --recursive src/socket_vmnet
cd src/socket_vmnet && git clean -f -d
cd src/socket_vmnet && PREFIX=$(SOCKET_VMNET_TEMP_PREFIX) $(MAKE) install.bin
cd src/socket_vmnet && PREFIX=$(SOCKET_VMNET_TEMP_PREFIX) "$(MAKE)" install.bin

.PHONY: download-sources
download-sources:
Expand Down

0 comments on commit 1b7aeb2

Please sign in to comment.