Make unit testing (usually) mandatory #16371
Merged
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
Could a minimum coverage requirement also be added to the pre-commit? Not sure of a good way to do that without blocking all new PRs in the immediate though... |
|
Yea @brycecf minimum coverage is pretty hard in CICD, especially with a monorepo |
|
@brycecf it would be a bit invasive doing it in the pre-commit, but I would support having a CI check in the PR, services like codecov can even leave comments to explain how the current coverage went down |
|
@masci would codecov only check coverage for the latest changes in a given PR? |
|
@logan-markewich yes, the coverage would be measured against the PR branch and compared with main, showing how it would change after merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16370