Added code to allow users to specify inference parameters for Huggingface models using HuggingfaceInferenceAPI #15680
+79
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
| "The value of the stop parameter to use when generating text. This parameter" | ||
| " is used to stop generating text when one of the specified tokens is generated." | ||
| ), | ||
| ) |
There was a problem hiding this comment.
None of these parameters are used though? Seems like there needs to be some function to get model kwargs when using the client?
There was a problem hiding this comment.
Yes! Sorry for the oversight. Correct me if I am wrong - link - here we can add these extra arguments. I am new to open-source contributions, I would really appreciate some guidance.
There was a problem hiding this comment.
Hmm, not in the metadata, but I think these options need to be passed when using the clients, like here
Probably we want a helper function to gather up the kwargs, and then each time a client is used, that function can help gather all the kwargs and send them along
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to issue #15659 - I added code to allow users to specify inference parameters for Huggingface models using HuggingfaceInferenceAPI . Refer to link to see how this code integrates with huggingface.
Fixes #15659
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist: