Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More renaming env to process/servlet #1563

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

carolineechen
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@carolineechen carolineechen force-pushed the 12-10-Remove_usage_of_.env_in_tests branch from 0bfe7e0 to e91fc24 Compare December 10, 2024 20:14
@carolineechen carolineechen force-pushed the 12-10-Remove_usage_of_.env_in_tests branch from e91fc24 to e3152e3 Compare December 10, 2024 22:16
@carolineechen carolineechen force-pushed the 12-10-Remove_usage_of_.env_in_tests branch from e3152e3 to b5b969e Compare December 10, 2024 22:18
@carolineechen carolineechen force-pushed the renaming-env branch 2 times, most recently from e16bfb3 to 6817dc6 Compare December 10, 2024 22:22
Base automatically changed from 12-10-Remove_usage_of_.env_in_tests to main December 11, 2024 15:55
Copy link

gitguardian bot commented Dec 11, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13571261 Triggered Generic Password b5b969e tests/test_resources/test_clusters/cluster_tests.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant