periodic cluster checks loop sends info logs in debug mode #1106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We send status to den using the httpx library. When the call succeeds, and info log is steamed to server.log file.
I set a WARNING log level for the httpx client in the cluster servlet, so info logs (
"HTTP/1.1 200 OK"
) won't be streamed. I set it only in the cluster servlet so it won't affect the httpx client in the http_client.py; the info logs streamed there is actually useful and do not spam the server.log file.Feels a bit "hacky" to set a separate logger to the httpx client in the cluster servlet, but it is a one-line solution that works. Open to discuss other ideas and solutions you may have :)