Disable Marshal in cache_store #5017
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5017 +/- ##
=======================================
Coverage 97.03% 97.03%
=======================================
Files 421 421
Lines 8776 8776
=======================================
Hits 8516 8516
Misses 260 260 ☔ View full report in Codecov by Sentry. |
colby-swandale
approved these changes
Sep 12, 2024
Move from :json_allow_marshal to :json Fixes TOB-RGM-3
simi
reviewed
Sep 30, 2024
| @@ -25,7 +25,7 @@ | |||
| config.action_controller.enable_fragment_cache_logging = true | |||
|
|
|||
| config.cache_store = :mem_cache_store, | |||
| { compress: true, compression_min_size: 524_288 } | |||
| { compress: true, compression_min_size: 524_288, serializer: :json } | |||
There was a problem hiding this comment.
failure points to this hash is missing :json key
simi
force-pushed
the
segiddins/disable-marshal-in-cache_store
branch
from
b29d3f1
to
388743e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from :json_allow_marshal to :json
Fixes TOB-RGM-3