Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

709 adding species to default pet tasks #879

Merged
merged 3 commits into from
Jul 21, 2024
Merged

709 adding species to default pet tasks #879

merged 3 commits into from
Jul 21, 2024

Conversation

atbalaji
Copy link
Contributor

🔗 Issue

#709

✍️ Description

  • Added species related filtering to default pet tasks

📷 Screenshots/Demos

@kasugaijin
Copy link
Collaborator

Thanks this is much easier for review @atbalaji

@jmilljr24 jmilljr24 mentioned this pull request Jul 19, 2024
Closed
kasugaijin
kasugaijin approved these changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@kasugaijin kasugaijin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @atbalaji
I will approve and merge this now, without tests. This will save you having to re-write migrations after I merge this PR.
I will make a new issue to add/update tests for this feature and tag you.

@kasugaijin kasugaijin merged commit 554ca4c into rubyforgood:main Jul 21, 2024
5 checks passed
@kasugaijin kasugaijin mentioned this pull request Jul 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasugaijin kasugaijin kasugaijin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atbalaji @kasugaijin