* Replace :with_item trait with calls to KitCreateService to make it easy
  to change line_item itemizable behavior later
* Remove unnecessary :with_item traits
* Hard code all rspecs matching against kit values, finishes rubyforgood#4217 for kits

* Another typo in docs

* Clearer name
* Add rspecs to test :housing_a_kit and :loose scopes

… deletion

* Move seed_base_items code into one static function
* Move kit base item creation code into one static function
* Add code to prevent calling destroy on kit base item and corresponding rspec
* Added comments - not sure about whether other base item request specs are useful or what the purpose of destroy is in the controller if it can't be called

* All SQL code is duplicated in AcquisitionReportService
* RSpec is close enough to what is in AcquisitionReportService Spec that it can be removed without merging in
  (only difference is Diapers - Adult Briefs category is not created, but that shouldn't matter
  because the SQL looks for %diaper% so this category isn't testing anything different)

…rgood#4163"

This reverts commit ceec002.

This reverts commit 7cabfa6.

This reverts commit 1109170.

This reverts commit b9b8755.

…ase_item deletion"

This reverts commit 8c18e42.

This reverts commit e1e2c31.

This reverts commit 141d959.

This reverts commit 080721e.