Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Ruby 3.2 #3950

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Upgrade to Ruby 3.2 #3950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2760d8
Upgrade to Ruby 3.2
dorner Nov 26, 2023
d95625f
gemfile.lock
dorner Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.1.2
3.2.2
2 changes: 0 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ git_source(:github) do |repo_name|
"https://github.com/#{repo_name}.git"
end

ruby "3.1.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this deleted by mistake? bundler needs to know the ruby version.
Is there a hook within the project for the bundler to read from .ruby-version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not a mistake - Cloud66 [explicitly says to delete this](https://help.cloud66.com/docs/build-and-config/managing-and-upgrading-ruby-versions#how-we-determine-the-version-to-use). It's not needed within the Gemfile. If you're using a Ruby version manager like RVM or asdf, it'll use .ruby-version. We control the version on CI with our GitHub Actions file, and Cloud66 uses the manifest file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha! And @dorner have you noticed any issue with this in local development? ( I like the code when it is more explicit than implicit. ) Cloud66 checks the version in manifest file first. So we can have it in both the places to satisfy local dev & deployment. Thoughts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, haven't noticed any issue. I left in .ruby-version which would power local dev.


###### BASIC FRAMEWORKS ######

# User management and login workflow.
Expand Down
3 changes: 0 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,8 +741,5 @@ DEPENDENCIES
web-console
webmock (~> 3.19)

RUBY VERSION
ruby 3.1.2p20

BUNDLED WITH
2.4.22
3 changes: 3 additions & 0 deletions manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
rails:
configuration:
ruby_version: 3.2.2
Loading