Fix infinite redirect loop for user without organization and that is not superuser, nor partner #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Specs are passing locally... failing in workflow... weird ill figure it out |
lokisk1155
changed the title
awwaiid
reviewed
Aug 2, 2023
public/403.html
Outdated
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <title>The page you were looking for doesn't exist (404)</title> |
There was a problem hiding this comment.
Smallllll change, but this title doesn't match the body.
|
Sorry I missed that you re-reviewed; hoping tests pass now |
|
@awwaiid I really don't want to talk about why it took so long to get passing specs... but it's good to go |
lokisk1155
changed the title
dorner
requested changes
Aug 11, 2023
|
@lokisk1155: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue with an infinite redirect loop that occurs for users who do not have an organization assigned and are not superusers or partners. After the change, the sign-in form responds with a 404 page instead of the infinite loop.
Such a case is not expected to exist in the wild, so it wasn't a serious problem. If such a case occurs, there will be needed some intervention anyway.
Slack ref: https://rubyforgood.slack.com/archives/C6WLZL0DD/p1684611196815299
Type of change
How Has This Been Tested?
Steps: