Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Date Entered on Purchase View #3699

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Conversation

lawilli
Copy link
Collaborator

@lawilli lawilli commented Jun 28, 2023

Resolves #3697

Description

Modified template to use issued_at rather than created_at for the Purchase Date column of a purchase view page.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  1. Create a new Purchase with a Purchase Date of 2 weeks prior (e.g. June 14 2023 as shown in the screenshot)
  2. Navigate to the Purchase's view page
  3. The Purchase Date of the column should list the same purchase date as entered previously. In parentheses, the date of entry should be shown.
  4. Observe that the breadcrumb reflects the Purchase Date rather than the date of entry.

Tests have also been included.

Screenshots

Screenshot 2023-06-29 at 9 13 52 AM

@lawilli lawilli changed the title Show Date Entered on Purchase View [WIP] Show Date Entered on Purchase View Jun 29, 2023
@lawilli lawilli changed the title [WIP] Show Date Entered on Purchase View Show Date Entered on Purchase View Jun 29, 2023
@lawilli lawilli requested review from seanmarcia and cielf June 29, 2023 15:07
@lawilli lawilli marked this pull request as ready for review June 29, 2023 15:08
Copy link
Member

@seanmarcia seanmarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR! Thanks for also catching, and fixing, that the breadcrumb was showing the wrong date as well!

@seanmarcia seanmarcia merged commit 86b79e5 into main Jun 29, 2023
11 checks passed
@seanmarcia seanmarcia deleted the use-issued_at-in-show-purchase branch June 29, 2023 18:41
@cielf
Copy link
Collaborator

cielf commented Jul 10, 2023

Thanks @lawilli ! -- we pushed this to production this morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Date of purchase on purchase view should shows date entered instead.
3 participants