Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "pragma-patch.diff" on MacOS Ventura 13.1 / Xcode 14.2 (#925) #938

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

openvmp
Copy link

@openvmp openvmp commented Jan 6, 2023

Work-around the problems that are most probably caused by the use of Windows new-line characters in the patch file.

@Yadunund
Copy link
Member

Hi @openvmp ,

Thanks for tracking down the malformed patch issue. I was able to reproduce it and applying your diff helps to resolve it. However I encountered additional errors which I've documented here #943 and was able to resolve with #944.
Are you able to comment on whether you also encountered those issues and if so, does my PR resolve them?

@openvmp
Copy link
Author

openvmp commented Jan 24, 2023

Hi Yadunund,

Sorry, can't help there.
I was not able to get far enough in the build process to get to the other packages in question due to issues with Python installation on that workstation.

Thanks
Roman

@karelok
Copy link

karelok commented Jan 10, 2024

Hi @openvmp,
I tested your update on macOS Sonoma (ARM) and it help to succesfully build rviz_ogre_vendor

Thanks!
K.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants