jazzy release note: callbacks in the executor are no longer ordered. #4459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya.Fujita <[email protected]>
fujitatomoya
requested review from
ahcorde
and removed request for
clalancette and
audrow
|
@clalancette @wjwwood @mjcarroll either of you, can you take a look? related to ros2/rclcpp#2532 |
fujitatomoya
commented
May 15, 2024
clalancette
requested changes
May 15, 2024
Signed-off-by: Tomoya.Fujita <[email protected]>
|
@clalancette thank you for the review. i just went ahead to borrow your suggested fixes. |
ahcorde
approved these changes
May 15, 2024
mjcarroll
approved these changes
May 16, 2024
clalancette
reviewed
May 16, 2024
Signed-off-by: Tomoya.Fujita <[email protected]>
|
@clalancette WDYT? i think it is more clear now. |
|
note: requesting backport only to jazzy. |
clalancette
approved these changes
May 16, 2024
I'm actually going to backport to all branches, because we still maintain the release notes on all branches for now. |
clalancette
added
the
backport-all
delete-merged-branch
bot
deleted the
fujitatomoya/jazzy-release-executor-callback-order
branch
mergify bot
pushed a commit
that referenced
this pull request
May 16, 2024
…4459) * jazzy release note: callbacks in the executor are no longer ordered. Signed-off-by: Tomoya.Fujita <[email protected]> (cherry picked from commit 931688a)
mergify bot
pushed a commit
that referenced
this pull request
May 16, 2024
…4459) * jazzy release note: callbacks in the executor are no longer ordered. Signed-off-by: Tomoya.Fujita <[email protected]> (cherry picked from commit 931688a)
mergify bot
pushed a commit
that referenced
this pull request
May 16, 2024
…4459) * jazzy release note: callbacks in the executor are no longer ordered. Signed-off-by: Tomoya.Fujita <[email protected]> (cherry picked from commit 931688a)
This was referenced May 16, 2024
clalancette
pushed a commit
that referenced
this pull request
May 16, 2024
…4459) (#4471) * jazzy release note: callbacks in the executor are no longer ordered. Signed-off-by: Tomoya.Fujita <[email protected]> (cherry picked from commit 931688a) Co-authored-by: Tomoya Fujita <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
May 16, 2024
…4459) (#4472) * jazzy release note: callbacks in the executor are no longer ordered. Signed-off-by: Tomoya.Fujita <[email protected]> (cherry picked from commit 931688a) Co-authored-by: Tomoya Fujita <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
May 16, 2024
…4459) (#4473) * jazzy release note: callbacks in the executor are no longer ordered. Signed-off-by: Tomoya.Fujita <[email protected]> (cherry picked from commit 931688a) Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of ros2/rclcpp#2532