Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom parameter bridge node names #402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ayushghosh21
Copy link

In cases where you may need to run multiple parameter bridges at the same time (eg: in multiple docker containers connected to the same ROS1 master) I was unable to run due to bridge nodes containing the same name. Initially passing in a command to rename the ros2 bridge is not successful because ROS1 and ROS2 parse the command line arguments differently.

Here, I am simply accounting for that, by reformatting the command line argument passed into ROS1 bridge node. This way I am able to specify custom names for the parameter bridge and therefore run multiple instances of the parameter bridge.

You can now simply pass in the arguments for a custom node name for the parameter bridge:

ros2 run ros1_bridge parameter_bridge --ros-args -r __node:=my_custom_name

@LucasHaug
Copy link

Heey @ayushghosh21, maybe it can help you, I opened the PR #396 some time ago and with the changes I did there you can change any ROS arg for the ROS 1 and the ROS 2 nodes, including the name, namespace and so on.

ipa-rwu added a commit to ipa-rwu/ros1_bridge that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants