-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zenoh 1.0.0 Porting #276
base: rolling
Are you sure you want to change the base?
Zenoh 1.0.0 Porting #276
Conversation
Signed-off-by: Luca Cominardi <[email protected]>
Signed-off-by: Luca Cominardi <[email protected]>
Signed-off-by: Luca Cominardi <[email protected]>
chore: checkout dev/1.0.0
…n the zenoh_c_vendor
Sorry. I think my previous conflict merge was unexpectedly corrupted. I have updated a new one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thread PR was merged, do you mind to rebase? There are some conflicts
@YuanYuYuan on top of what Alex mentioned above we also merged a few PRs to make a few tests pass. Could you slowly incorporate those changes into this PR as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is defined liveliness_is_valid
in the rmw_publisher_data.hpp
header, but it's not implemented. Maybe it was lost in the rebase
The |
@ahcorde @Yadunund I've merged the latest thread-safe PRs into this branch with the additional changes below.
NOTE: The rolling/jazzy uncrustify seems to be incompatible with the iron one. I will review the style change manually. |
Just as an FYI; it should be possible, in most cases, to update the style so that it will satisfy both. The big exception to this is in macros, where I could not find a consistent set of configuration or code that satisfies both older uncrustify and newer one. But I don't believe we use too many macros here, so hopefully this is not the issue. |
Hi @clalancette, according to the logs, those are not macros. Maybe we have other issues? 🤔 https://github.com/ros2/rmw_zenoh/actions/runs/11148592945/job/30985531516?pr=276#step:4:5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YuanYuYuan I merged the PR that fixed the lifecycle issue, do you mind to rebase again with rolling
?
Signed-off-by: ChenYing Kuo <[email protected]>
… a subscriber after the RMW has been shut down
Notes
z_view_keyexpr_t
ratherz_owned_keyexpr_t
if possible. This keeps the reference only and doesn't need to be dropped.z_check
is now internal. We check zenoh entities' health by the creation functions' return.